Replace ** and Recursivedir for FastestCP test #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snixtho
approved these changes
Sep 29, 2024
snixtho
approved these changes
Sep 29, 2024
flaeri
force-pushed
the
fix-recursive-path
branch
2 times, most recently
from
b7c73d1
to
52b51b8
Compare
When building on windows via commandline (both cmd and pwsh), it woudl fail to find the Manialinks, and could also accidentally create a bunch of recursive folders while trying to copy said files
flaeri
force-pushed
the
fix-recursive-path
branch
from
52b51b8
to
6f56483
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building on windows via commandline (both cmd and pwsh), it would fail to find the Manialinks in FastestCP tests, and could also accidentally create a bunch of recursive folders while trying to copy said files.
Testing building via powershell on windows, by being in the git root, and running
dotnet buildIt now successfully finds the manialinks, and no longer recursively creates nested
bin\Debug\net8.0folders.If someone on links could confirm that building still works, that would be most appreciated